Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust queries for operations that use only a transaction ID #644

Open
awrichar opened this issue Mar 29, 2022 · 0 comments
Open

Adjust queries for operations that use only a transaction ID #644

awrichar opened this issue Mar 29, 2022 · 0 comments

Comments

@awrichar
Copy link
Contributor

There are a few queries to GetOperations that attempt to load operation inputs only by looking at the operation type and the transaction ID. One example:

fb.Eq("type", fftypes.OpTypeTokenTransfer),

Due to operation resubmission, transactions may now contain multiple operations of a given type, meaning that there is a potential source of confusion here in terms of which operation is loaded. It may not matter if all the operations have identical inputs (which is currently the case for retries) - but worth double-checking that this doesn't cause problems now or in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant