Add build to PR checks

Author: peterbroadhurst

.github/workflows/tsc.yml

@@ -0,0 +1,23 @@
+name: Typescript
+
+on:
+  push:
+    branches: [main]
+  pull_request:
+    branches: [main]
+  workflow_dispatch:
+
+jobs:
+  build:
+    name: tsc
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v1
+    - name: install node v16
+      uses: actions/setup-node@v1
+      with:
+        node-version: 16
+    - name: npm install
+      run: npm install
+    - name: tsc
+      uses: icrawl/action-tsc@v1

src/handlers/blobs.ts

@@ -105,7 +105,7 @@ export const deliverBlob = async ({ blobPath, recipient, recipientURL, requestID
       requestID
     } as IBlobDeliveredEvent);
     log.trace(`Blob delivered`);
-  } catch (err) {
+  } catch (err: any) {
     eventEmitter.emit('event', {
       id: uuidV4(),
       type: 'blob-failed',

src/handlers/messages.ts

@@ -63,7 +63,7 @@ export const deliverMessage = async ({ message, recipient, recipientURL, request
       requestID
     } as IMessageDeliveredEvent);
     log.trace(`Message delivered`);
-  } catch(err) {
+  } catch(err: any) {
     eventEmitter.emit('event', {
       id: uuidV4(),
       type: 'message-failed',

src/lib/config.ts

@@ -42,7 +42,7 @@ const loadConfig = async () => {
     try {
       log.debug(`Reading peers file ${peersFilePath}`);
       data.peers = JSON.parse(await fs.readFile(peersFilePath, 'utf8'));
-    } catch (err) {
+    } catch (err: any) {
       // if file does not exist, just set peers to either the peers from config.json (if migrating from older version) or to an empty list
       log.debug(`Error code when reading peers file ${err.code}`);
       if (err.code === 'ENOENT') {
@@ -75,7 +75,7 @@ export const persistPeers = async () => {
 const ensurePeersDirectoryExists = async () => {
   try {
     await fs.access(peersFilePath);
-  } catch(err) {
+  } catch(err: any) {
     if(err.code === 'ENOENT') {
       await createPeersDirectory();
     } else {
@@ -88,7 +88,7 @@ const createPeersDirectory = async () => {
   try {
     await fs.mkdir(path.parse(peersFilePath).dir, { recursive: true });
     log.info('Peers subdirectory created');
-  } catch(err) {
+  } catch(err: any) {
     log.error(`Failed to create peers subdirectory ${err.code}`);
   }
 };

src/lib/utils.ts

@@ -15,7 +15,7 @@
 // limitations under the License.
 
 import axios, { AxiosRequestConfig } from 'axios';
-import Busboy from 'busboy';
+import Busboy, { BusboyHeaders } from 'busboy';
 import { Request } from 'express';
 import { promises as fs } from 'fs';
 import { X509 } from 'jsrsasign';
@@ -54,7 +54,7 @@ export const fileExists = async (filePath: string): Promise<boolean> => {
   try {
     const stats = await fs.stat(filePath);
     return !stats.isDirectory();
-  } catch (err) {
+  } catch (err: any) {
     if (err.errno === -2) {
       return false;
     } else {
@@ -67,7 +67,7 @@ export const fileExists = async (filePath: string): Promise<boolean> => {
 export const extractFileFromMultipartForm = (req: Request): Promise<IFile> => {
   return new Promise(async (resolve, reject) => {
     let fileFound = false;
-    req.pipe(new Busboy({ headers: req.headers })
+    req.pipe(new Busboy({ headers: req.headers as BusboyHeaders })
       .on('file', (fieldname, readableStream, fileName) => {
         fileFound = true;
         resolve({
@@ -86,7 +86,7 @@ export const extractFileFromMultipartForm = (req: Request): Promise<IFile> => {
 export const extractMessageFromMultipartForm = (req: Request): Promise<string> => {
   return new Promise(async (resolve, reject) => {
     let fieldFound = false;
-    req.pipe(new Busboy({ headers: req.headers })
+    req.pipe(new Busboy({ headers: req.headers as BusboyHeaders })
       .on('field', (fieldname, value) => {
         if(fieldname === 'message') {
           fieldFound = true;
@@ -107,7 +107,7 @@ export const axiosWithRetry = async (config: AxiosRequestConfig) => {
     try {
       log.debug(`${config.method} ${config.url}`);
       return await axios(config);
-    } catch (err) {
+    } catch (err: any) {
       const data = err.response?.data;
       log.error(`${config.method} ${config.url} attempt ${attempts} [${err.response?.status}]`, (data && !data.on) ? data : err.stack);
       if (err.response?.status === 404) {

src/routers/api.ts

@@ -113,7 +113,7 @@ router.delete('/peers/:id', async (req, res, next) => {
     }
     try {
       await fs.rm(path.join(utils.constants.DATA_DIRECTORY, utils.constants.PEER_CERTS_SUBDIRECTORY, `${req.params.id}.pem`));
-    } catch (err) {
+    } catch (err: any) {
       if (err.errno !== -2) {
         throw new RequestError(`Failed to remove peer certificate`);
       }