Skip to content

Commit e11591e

Browse files
committed
[FAB-6350] DeliverService CI failure: serve < register
The orderer service mock in the deliver service package tries to register a gRPC server after serve might be called. This is forbidden in the latest gRPC version. the error is: 17:39:38 unit-tests_1 | 2017-09-29 17:39:38.437 UTC [grpc] Fatalf -> CRIT 06a grpc: Server.RegisterService after Server.Serve for "orderer.AtomicBroadcast" 17:39:38 unit-tests_1 | FAIL github.com/hyperledger/fabric/core/deliverservice 7.090s 17:39:38 unit-tests_1 | error: exit status 1 17:39:38 unit-tests_1 | panic: EOF Change-Id: I04b2ccc25ba6978ad3848571030515f051f71622 Signed-off-by: yacovm <yacovm@il.ibm.com>
1 parent a3a769d commit e11591e

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

core/deliverservice/mocks/orderer.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@ func NewOrderer(port int, t *testing.T) *Orderer {
3636
if err != nil {
3737
panic(err)
3838
}
39-
go srv.Serve(lsnr)
4039
o := &Orderer{Server: srv,
4140
Listener: lsnr,
4241
t: t,
@@ -45,6 +44,7 @@ func NewOrderer(port int, t *testing.T) *Orderer {
4544
stopChan: make(chan struct{}, 1),
4645
}
4746
orderer.RegisterAtomicBroadcastServer(srv, o)
47+
go srv.Serve(lsnr)
4848
return o
4949
}
5050

0 commit comments

Comments
 (0)