[FAB-12255] set testing.T needed by testify

Newer versions of testify panic when a nil testing.T is used on
assertions so fix the wiring.

Change-Id: If8cb4d6405ed4a3b9e18fcdf148b18fcee16bbb7
Signed-off-by: Matthew Sykes <sykesmat@us.ibm.com>

Author: sykesm

core/chaincode/accesscontrol/access_test.go

@@ -91,6 +91,7 @@ func newCCServer(t *testing.T, port int, expectedCCname string, withTLS bool, ca
 	l, err := net.Listen("tcp", fmt.Sprintf("%s:%d", "", port))
 	assert.NoError(t, err, "%v", err)
 	return &ccSrv{
+		t:              t,
 		expectedCCname: expectedCCname,
 		l:              l,
 		grpcSrv:        s,

core/committer/txvalidator/plugin_validator_test.go

@@ -90,7 +90,7 @@ func TestSamplePlugin(t *testing.T) {
 	capabilites := &mocks.Capabilities{}
 	capabilites.On("PrivateChannelData").Return(true)
 	factory := &mocks.PluginFactory{}
-	factory.On("New").Return(&testdata.SampleValidationPlugin{})
+	factory.On("New").Return(testdata.NewSampleValidationPlugin(t))
 	pm["vscc"] = factory
 
 	transaction := testdata.MarshaledSignedData{

core/committer/txvalidator/testdata/test_plugin.go

@@ -30,6 +30,12 @@ type SampleValidationPlugin struct {
 	pe PolicyEvaluator
 }
 
+// NewSampleValidationPlugin returns an instance of a validation plugin setup
+// for assertions.
+func NewSampleValidationPlugin(t *testing.T) *SampleValidationPlugin {
+	return &SampleValidationPlugin{t: t}
+}
+
 type MarshaledSignedData struct {
 	Data      []byte `protobuf:"bytes,1,opt,name=data,proto3" json:"data,omitempty"`
 	Signature []byte `protobuf:"bytes,2,opt,name=signature,proto3" json:"signature,omitempty"`

core/committer/txvalidator/validator_test.go

@@ -1599,7 +1599,7 @@ func createCustomSupportAndLedger(t *testing.T) (*mocktxvalidator.Support, ledge
 
 func TestDynamicCapabilitiesAndMSP(t *testing.T) {
 	factory := &mocks.PluginFactory{}
-	factory.On("New").Return(&testdata.SampleValidationPlugin{})
+	factory.On("New").Return(testdata.NewSampleValidationPlugin(t))
 	pm := &mocks.PluginMapper{}
 	pm.On("PluginFactoryByName", txvalidator.PluginName("vscc")).Return(factory)
 

core/deliverservice/requester_test.go

@@ -50,7 +50,7 @@ func TestTLSBinding(t *testing.T) {
 	})
 	assert.NoError(t, err)
 
-	orderer.RegisterAtomicBroadcastServer(s.Server(), &mockOrderer{})
+	orderer.RegisterAtomicBroadcastServer(s.Server(), &mockOrderer{t: t})
 	go s.Start()
 	defer s.Stop()
 	time.Sleep(time.Second * 3)