Skip to content

Commit 9dea224

Browse files
committed
[FAB-13086] longer wait for term in healh check
Also cleanup the dangling network and test directory. Change-Id: I145e4d97ed5bb0c7513c71ad8e0b7d6525f01128 Signed-off-by: Matthew Sykes <sykesmat@us.ibm.com>
1 parent 5ab30b8 commit 9dea224

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

integration/e2e/acl_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ var _ = Describe("EndToEndACL", func() {
8383

8484
AfterEach(func() {
8585
process.Signal(syscall.SIGTERM)
86-
Eventually(process.Wait()).Should(Receive())
86+
Eventually(process.Wait(), network.EventuallyTimeout).Should(Receive())
8787
network.Cleanup()
8888
os.RemoveAll(testDir)
8989
})

integration/e2e/health_test.go

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ import (
1111
"fmt"
1212
"io/ioutil"
1313
"net/http"
14+
"os"
1415
"syscall"
1516

1617
docker "github.com/fsouza/go-dockerclient"
@@ -45,9 +46,13 @@ var _ = Describe("Health", func() {
4546

4647
AfterEach(func() {
4748
if process != nil {
48-
process.Signal(syscall.SIGKILL)
49-
Eventually(process.Wait).Should(Receive())
49+
process.Signal(syscall.SIGTERM)
50+
Eventually(process.Wait, network.EventuallyTimeout).Should(Receive())
5051
}
52+
if network != nil {
53+
network.Cleanup()
54+
}
55+
os.RemoveAll(testDir)
5156
})
5257

5358
Context("when the docker config is bad", func() {

0 commit comments

Comments
 (0)