[FAB-10954] data race core/comm/producer

sykesm · sykesm · commit 9dcaed640fab · 2018-07-02T08:24:43.000-04:00
TestUpdateEndpoints was modifying package scoped variables while all of
the other tests were concurrently reading it. This is a race.

Disabling parallel execution for this test.

Change-Id: Ic3979ddba54685ced5ac9eb7111d0d3cf4b34053
Signed-off-by: Matthew Sykes &lt;sykesmat@us.ibm.com&gt;
diff --git a/core/comm/producer_test.go b/core/comm/producer_test.go
@@ -100,7 +100,6 @@ func TestUpdateEndpoints(t *testing.T) {
 }
 
 func TestDisableEndpoint(t *testing.T) {
-	t.Parallel()
 	orgEndpointDisableInterval := EndpointDisableInterval
 	EndpointDisableInterval = time.Millisecond * 100
 	defer func() { EndpointDisableInterval = orgEndpointDisableInterval }()

Original file line number	Diff line number	Diff line change
`@@ -100,7 +100,6 @@ func TestUpdateEndpoints(t *testing.T) {`
`100`	`100`	`}`
`101`	`101`
`102`	`102`	`func TestDisableEndpoint(t *testing.T) {`
`103`		`- t.Parallel()`
`104`	`103`	`orgEndpointDisableInterval := EndpointDisableInterval`
`105`	`104`	`EndpointDisableInterval = time.Millisecond * 100`
`106`	`105`	`defer func() { EndpointDisableInterval = orgEndpointDisableInterval }()`