Skip to content

Commit 90df55d

Browse files
author
Luis Sanchez
committed
[FAB-7873] Update sarama kafka client to v1.15.0
- even more forgiving kafka version parsing - removed default Kafka.Version from orderer.yaml - kept default value of Kafka.Version in orderer binary as 0.10.2.0 (future changeset to move this to 1.0.0 once kafka image has been updated) Change-Id: I9220fccd6ebb03529458367c21dd0256483abb8c Signed-off-by: Luis Sanchez <sanchezl@us.ibm.com>
1 parent 88fd880 commit 90df55d

19 files changed

+410
-78
lines changed

common/viperutil/config_test.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,8 @@ func TestKafkaVersionDecode(t *testing.T) {
101101
{"1", sarama.V1_0_0_0, false},
102102
{"1.0", sarama.V1_0_0_0, false},
103103
{"1.0.0", sarama.V1_0_0_0, false},
104-
{"1.0.1", sarama.V1_0_0_0, true},
104+
{"1.0.1", sarama.V1_0_0_0, false},
105+
{"2.0.0", sarama.V1_0_0_0, false},
105106
{"Malformed", sarama.KafkaVersion{}, true},
106107
}
107108

common/viperutil/config_util.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -260,7 +260,7 @@ func init() {
260260
kafkaVersionConstraints[sarama.V0_10_1_0], _ = version.NewConstraint(">=0.10.1.0,<0.10.2.0")
261261
kafkaVersionConstraints[sarama.V0_10_2_0], _ = version.NewConstraint(">=0.10.2.0,<0.11.0.0")
262262
kafkaVersionConstraints[sarama.V0_11_0_0], _ = version.NewConstraint(">=0.11.0.0,<1.0.0")
263-
kafkaVersionConstraints[sarama.V1_0_0_0], _ = version.NewConstraint(">=1.0.0,<1.0.1")
263+
kafkaVersionConstraints[sarama.V1_0_0_0], _ = version.NewConstraint(">=1.0.0")
264264
}
265265

266266
func kafkaVersionDecodeHook() mapstructure.DecodeHookFunc {

sampleconfig/orderer.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -246,7 +246,7 @@ Kafka:
246246

247247
# Kafka protocol version used to communicate with the Kafka cluster brokers
248248
# (defaults to 0.10.2.0 if not specified)
249-
Version: 0.10.2.0
249+
Version:
250250

251251
################################################################################
252252
#

vendor/github.com/Shopify/sarama/CHANGELOG.md

Lines changed: 26 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/github.com/Shopify/sarama/broker.go

Lines changed: 7 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/github.com/Shopify/sarama/create_partitions_request.go

Lines changed: 121 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/github.com/Shopify/sarama/create_partitions_response.go

Lines changed: 94 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/github.com/Shopify/sarama/dev.yml

Lines changed: 0 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)