[FAB-8481] suppress file system info from error

Output internal error as an error log and suppress
it from error returned to user.

Change-Id: I2c9e41a7412276af30cdc531dc6cb74359373b50
Signed-off-by: Srinivasan Muralidharan <srinivasan.muralidharan99@gmail.com>

Author: muralisrini

core/scc/lscc/lscc.go

@@ -465,7 +465,9 @@ func (lscc *lifeCycleSysCC) executeDeployOrUpgrade(
 
 	ccpack, err := lscc.support.GetChaincodeFromLocalStorage(cds.ChaincodeSpec.ChaincodeId.Name, cds.ChaincodeSpec.ChaincodeId.Version)
 	if err != nil {
-		return nil, fmt.Errorf("cannot get package for chaincode (%s:%s)-%s", cds.ChaincodeSpec.ChaincodeId.Name, cds.ChaincodeSpec.ChaincodeId.Version, err)
+		retErrMsg := fmt.Sprintf("cannot get package for chaincode (%s:%s)", cds.ChaincodeSpec.ChaincodeId.Name, cds.ChaincodeSpec.ChaincodeId.Version)
+		logger.Errorf("%s-err:%s", retErrMsg, err)
+		return nil, fmt.Errorf("%s", retErrMsg)
 	}
 	cd := ccpack.GetChaincodeData()
 

core/scc/lscc/lscc_test.go

@@ -167,7 +167,7 @@ func TestDeploy(t *testing.T) {
 
 	testDeploy(t, "example02", "0", path, false, false, true, "", nil, nil)
 	testDeploy(t, "example02", "1.0", path, false, false, true, "", nil, nil)
-	testDeploy(t, "example02", "1.0", path, false, false, false, "cannot get package for chaincode (example02:1.0)-barf", nil, nil)
+	testDeploy(t, "example02", "1.0", path, false, false, false, "cannot get package for chaincode (example02:1.0)", nil, nil)
 	testDeploy(t, "example02", "0", path, true, false, true, EmptyChaincodeNameErr("").Error(), nil, nil)
 	testDeploy(t, "example02", "0", path, false, true, true, EmptyVersionErr("example02").Error(), nil, nil)
 	testDeploy(t, "example02.go", "0", path, false, false, true, InvalidChaincodeNameErr("example02.go").Error(), nil, nil)