[FAB-9643] Remove unreachable nil check

yacovm · yacovm · commit 4ceccd403b07 · 2018-04-22T16:37:23.000+03:00
This change set removes a nil check that is unreachable in the code.
The function retrieveCollectionConfigPackage can never return (nil, nil),
yet the caller function retrieveSimpleCollection checks for that condition.

Change-Id: I4731b5a219626aae081a39097666b10e2a06ae0f
Signed-off-by: yacovm &lt;yacovm@il.ibm.com&gt;
diff --git a/core/common/privdata/store.go b/core/common/privdata/store.go
@@ -77,9 +77,6 @@ func (c *simpleCollectionStore) retrieveSimpleCollection(cc common.CollectionCri
 	if err != nil {
 		return nil, err
 	}
-	if collections == nil {
-		return nil, nil
-	}
 
 	for _, cconf := range collections.Config {
 		switch cconf := cconf.Payload.(type) {

Original file line number	Diff line number	Diff line change
`@@ -77,9 +77,6 @@ func (c *simpleCollectionStore) retrieveSimpleCollection(cc common.CollectionCri`
`77`	`77`	`if err != nil {`
`78`	`78`	`return nil, err`
`79`	`79`	`}`
`80`		`- if collections == nil {`
`81`		`- return nil, nil`
`82`		`- }`
`83`	`80`
`84`	`81`	`for _, cconf := range collections.Config {`
`85`	`82`	`switch cconf := cconf.Payload.(type) {`