Skip to content

Conversation

bestbeforetoday
Copy link
Member

Use latest eclipse-termurin:11-jdk image to minimise exposure to security vulnerabilities in the base image.

Also:

  • Change permissions for Gradle publishing workflow to allow publish to GitHub Packages.
  • Update Bouncy Castle dependency to latest patch release (1.78 to 1.78.1).

@bestbeforetoday bestbeforetoday marked this pull request as ready for review May 10, 2024 10:28
@bestbeforetoday bestbeforetoday requested a review from a team as a code owner May 10, 2024 10:28
@bestbeforetoday bestbeforetoday enabled auto-merge (squash) May 10, 2024 10:28
Use latest eclipse-termurin:11-jdk image to minimise exposure to
security vulnerabilities in the base image.

Also:
- Change permissions for Gradle publishing workflow to allow publish to
  GitHub Packages.
- Update Bouncy Castle dependency to latest patch release (1.78 to
  1.78.1).
- Update version numbers.

Signed-off-by: Mark S. Lewis <Mark.S.Lewis@outlook.com>
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.3% Duplication on New Code

See analysis details on SonarCloud

@bestbeforetoday bestbeforetoday merged commit 3f3443c into hyperledger:main May 10, 2024
@denyeart
Copy link
Contributor

@bestbeforetoday I approved this one, but then noticed integration tests are failing in chaincode build due to
Could not resolve org.hyperledger.fabric-chaincode-java:fabric-chaincode-shim:2.5.2

@bestbeforetoday
Copy link
Member Author

@denyeart I realised that the versions numbers need to be updated since the last release. Doing that seems to cause issues with the integration tests since they pull from Maven Central, where the new version has not yet been published. It seems that something needs to change in the build so that the integration tests run against the current development code, not previously published code.

@bestbeforetoday
Copy link
Member Author

The branch protection rules really should not have allowed the merge to happen with a failing build either. I'll look into that.

@bestbeforetoday bestbeforetoday deleted the docker branch May 10, 2024 12:23
@bestbeforetoday
Copy link
Member Author

Pull request #344 reverts the version of fabric-chaincode-shim dependency on one of the integration test chaincodes so that the tests pass again. Really they should work with the current development version but that needs some more work on the build to resolve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants