Skip to content

Conversation

bestbeforetoday
Copy link
Member

@bestbeforetoday bestbeforetoday commented Feb 25, 2024

Include build of the Docker image in tests run on a pull request to ensure the Docker image at least builds cleanly.

The integration tests use builders baked into Microfab rather than real Fabric builders and the chaincode Docker images. This means the bare-gradle test chaincode is built using the Gradle version supplied by Microfab, not the version included in the Java chaincode Docker images, and has to be left with outdated plugin versions and build.gradle content.

Closes #326

@bestbeforetoday bestbeforetoday force-pushed the gradle branch 6 times, most recently from 251b497 to 7f1fc3e Compare February 25, 2024 22:38
@bestbeforetoday bestbeforetoday marked this pull request as ready for review February 25, 2024 22:48
@bestbeforetoday bestbeforetoday requested a review from a team as a code owner February 25, 2024 22:48
Include build of the Docker image in tests run on a pull request to ensure the Docker image at least builds cleanly.

The integration tests use builders baked into Microfab rather than real Fabric builders and the chaincode Docker images. This means the bare-gradle test chaincode is built using the Gradle version supplied by Microfab, not the version included in the Java chaincode Docker images, and has to be left with outdated plugin versions and build.gradle content.

Signed-off-by: Mark S. Lewis <Mark.S.Lewis@outlook.com>
Copy link

Quality Gate Passed Quality Gate passed

Issues
10 New issues

Measures
0 Security Hotspots
No data about Coverage
0.3% Duplication on New Code

See analysis details on SonarCloud

@denyeart denyeart merged commit fa056db into hyperledger:main Feb 27, 2024
@bestbeforetoday bestbeforetoday deleted the gradle branch February 27, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build Docker image in pull request tests

2 participants