Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve reliability of acceptance tests #830

Merged
merged 4 commits into from
May 6, 2020

Conversation

shemnon
Copy link
Contributor

@shemnon shemnon commented May 2, 2020

The acceptance tests have tests where a large number of besu processes
are stared and stopped, sometimes many at once. Instead of large
boxes this configuration relies on many boxes.

Signed-off-by: Danno Ferrin danno.ferrin@gmail.com

The acceptance tests have tests where a large number of besu processes
are stared and stopped, sometimes many at once.  Instead of large
boxes this configuration relies on many boxes.

Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
Copy link
Contributor

@atoulme atoulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. I see a performance speed up that is worth the trouble.

Copy link
Member

@usmansaleem usmansaleem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MadelineMurray MadelineMurray merged commit 820a426 into hyperledger:master May 6, 2020
@shemnon shemnon deleted the circleci branch May 7, 2020 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants