Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check JUMPF stack #7787

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

shemnon
Copy link
Contributor

@shemnon shemnon commented Oct 19, 2024

PR description

Rule 2 in EIP-6206 requires us to check stack prior to JUMPF

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

Rule 2 in EIP-6206 requires us to check stack prior to JUMPF

Signed-off-by: Danno Ferrin <danno@numisight.com>
@shemnon
Copy link
Contributor Author

shemnon commented Oct 19, 2024

test is here - ethereum/execution-spec-tests#902

Fails before this PR, passes after. It's the middle rule_overflow case that is relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant