Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Devnet4: 7702 spec changes #7754

Draft
wants to merge 34 commits into
base: main
Choose a base branch
from
Draft

Devnet4: 7702 spec changes #7754

wants to merge 34 commits into from
+1,004 −4,958

Conversation

daniellehrner
Copy link
Contributor

@daniellehrner daniellehrner commented Oct 10, 2024 •
edited
Loading

PR description

  • Warm target of delegated account if a delegated account is the transaction destination
  • restrict authorization nonce to 2**64 -1
  • fix gas calculation for code delegation resolution if target is precompile
  • verify auth nonce less than 2**64-1 during auth processing
  • auth to zero address deletes delegation
  • auth to precompile returns empty code
  • auth nonce < 2**8
  • increase auth base cost to 12500

Fixed Issue(s)

fixes #7706

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

daniellehrner and others added 11 commits October 2, 2024 16:07
@daniellehrner
warm up to address at tx start if account is delegated, restrict auth…
c71d4af 
… nonce to 2**64-1

Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
@daniellehrner
Merge branch 'main' into fix/issue-7706/warmup_to_when_delegated
67bab68
@jframe
rename requestsRoot to requestsHash
49a4411 
Signed-off-by: Jason Frame <jason.frame@consensys.net>
@daniellehrner
return no code if account has delegated code to precompile, treat pre…
196bf10 
…compile always as warm account when resolving code

Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
@daniellehrner
make accessListWarmAddresses generic again
a2abff2 
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
@daniellehrner
Merge branch 'fix/issue-7706/warmup_to_when_delegated' into pectra-de…
dcefdce 
…vnet3-block-110500-issue
@daniellehrner
warm delegatee account if transaction destination has delegated code
6393399 
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
@daniellehrner
Merge branch 'main' into pectra-devnet4-7702
1269cc1
@daniellehrner
* verify auth nonce less than 2**64-1 during auth processing
d7e5686 
* auth to zero address deletes delegation
* auth to precompile returns empty code
* auth nonce < 2**8
* increase auth base cost to 12500

Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
@jframe
generalised requests flat encoding and engine api changes
cdc9bd5 
Signed-off-by: Jason Frame <jason.frame@consensys.net>
@jframe
javadoc
cee6abc 
Signed-off-by: Jason Frame <jason.frame@consensys.net>
@jflo jflo added the Prague label Oct 14, 2024
jframe and others added 18 commits October 15, 2024 14:37
@jframe
get tests passing
8f346f4 
Signed-off-by: Jason Frame <jason.frame@consensys.net>
@jframe
get tests passing
4e12780 
Signed-off-by: Jason Frame <jason.frame@consensys.net>
@jframe
Merge remote-tracking branch 'upstream/main' into 7685_flat_encoding
42e6865
@jframe
clean code
f0d5a24 
Signed-off-by: Jason Frame <jason.frame@consensys.net>
@jframe
change requests to single requestData for each requestType
0424317 
Signed-off-by: Jason Frame <jason.frame@consensys.net>
@jframe
fix PoWBlockCreatorTest after requests data type change
86f5049 
Signed-off-by: Jason Frame <jason.frame@consensys.net>
@jframe
don't return request type in getPayload result
722823e 
Signed-off-by: Jason Frame <jason.frame@consensys.net>

don't return request type in getPayload result

Signed-off-by: Jason Frame <jason.frame@consensys.net>
@jframe
include requests in t8n response
24a33e7 
Signed-off-by: Jason Frame <jason.frame@consensys.net>
@jframe
update contract addresses for consolidation requests and withdrawal r…
24de847 
…equests

Signed-off-by: Jason Frame <jason.frame@consensys.net>
@jframe
fix requestHash calculation
532cb9d 
Signed-off-by: Jason Frame <jason.frame@consensys.net>
@jframe
Ensure that execution requests always return a response
079bcfd 
Signed-off-by: Jason Frame <jason.frame@consensys.net>
@daniellehrner
Merge branch 'main' into pectra-devnet4-7702
9a98c12
@daniellehrner
Merge remote-tracking branch 'jason/7685_flat_encoding' into pectra-d…
c19f93f 
…evnet4-7702
@daniellehrner
added and fixed bound checks, fixed some compilation errors after the…
bdb0cb3 
… rebase

Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
@jframe
revert changes to evm tool spec tests
eff46b0 
Signed-off-by: Jason Frame <jason.frame@consensys.net>
@jframe
clean up
1fdf0db 
Signed-off-by: Jason Frame <jason.frame@consensys.net>
@jframe
replace AbstractSystemCallRequestProcessor to concrete class and remo…
9c2a623 
…ve specific processors

Signed-off-by: Jason Frame <jason.frame@consensys.net>
@jframe
spotless
afd9023 
Signed-off-by: Jason Frame <jason.frame@consensys.net>
jframe and others added 5 commits October 17, 2024 16:03
@jframe
update evmtool tests for 7685 changes
20ca19e 
Signed-off-by: Jason Frame <jason.frame@consensys.net>
@jframe
use empty requests hash prague fork at genesis
3ee1b31 
Signed-off-by: Jason Frame <jason.frame@consensys.net>
@jframe
review suggestions
21b7aae 
Signed-off-by: Jason Frame <jason.frame@consensys.net>
@daniellehrner
Merge remote-tracking branch 'jason/7685_flat_encoding' into pectra-d…
6457be5 
…evnet4-7702
@daniellehrner
temporarily comment out osakaTime from Prague
7522a77 
Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Prague
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Devnet-3: Besu forked off at block 110500
3 participants
@daniellehrner @jflo @jframe