Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mining options refactor #6027

Merged
merged 25 commits into from
Oct 24, 2023
Merged

Mining options refactor #6027

merged 25 commits into from
Oct 24, 2023

Commits on Oct 10, 2023

  1. Refactor mining options 

    Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
    @fab-10
    fab-10 committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    c57c2ac View commit details
    Browse the repository at this point in the history

  2. Fix null pointer exception 

    Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
    @fab-10
    fab-10 committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    b408b64 View commit details
    Browse the repository at this point in the history

  3. fix another null pointer exception 

    Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
    @fab-10
    fab-10 committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    da79e09 View commit details
    Browse the repository at this point in the history

  4. uncomment code 

    Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
    @fab-10
    fab-10 committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    7684d7e View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2023

  1. Move miner options tests 

    Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
    @fab-10
    fab-10 committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    78741da View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2023

  1. Unit test fixes 

    Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
    @fab-10
    fab-10 committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    18bcce3 View commit details
    Browse the repository at this point in the history

  2. Removed the commented code 

    Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
    @fab-10
    fab-10 committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    59fbe8e View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2023

  1. WIP 

    Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
    @fab-10
    fab-10 committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    8f14dd3 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into mining-options-refactor 

    # Conflicts:
#	ethereum/blockcreation/src/main/java/org/hyperledger/besu/ethereum/blockcreation/txselection/BlockTransactionSelector.java
#	ethereum/blockcreation/src/test/java/org/hyperledger/besu/ethereum/blockcreation/AbstractBlockTransactionSelectorTest.java
#	plugin-api/build.gradle
    @fab-10
    fab-10 committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    2280e02 View commit details
    Browse the repository at this point in the history

  3. WIP 

    Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
    @fab-10
    fab-10 committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    65bdabd View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2023

  1. Remove not relevant for this feature 

    Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
    @fab-10
    fab-10 committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    e89a244 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into mining-options-refactor

    @fab-10
    fab-10 committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    20e498b View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2023

  1. Merge branch 'main' into mining-options-refactor 

    # Conflicts:
#	ethereum/blockcreation/src/main/java/org/hyperledger/besu/ethereum/blockcreation/txselection/selectors/PriceTransactionSelector.java
    @fab-10
    fab-10 committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    86b9a6e View commit details
    Browse the repository at this point in the history

  2. Fix javadoc 

    Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
    @fab-10
    fab-10 committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    2267bc7 View commit details
    Browse the repository at this point in the history

  3. Remove code not belonging to this PR 

    Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
    @fab-10
    fab-10 committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    c6b56d2 View commit details
    Browse the repository at this point in the history

  4. coinbase is an updatable parameter 

    Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
    @fab-10
    fab-10 committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    477acf9 View commit details
    Browse the repository at this point in the history

  5. Move MiningOptions to upper package 

    Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
    @fab-10
    fab-10 committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    4626230 View commit details
    Browse the repository at this point in the history

  6. Fix coinbase for *bft 

    Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
    @fab-10
    fab-10 committed Oct 17, 2023
    Configuration menu
    Copy the full SHA
    25b1522 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2023

  1. Merge branch 'main' into mining-options-refactor

    @fab-10
    fab-10 committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    ae775ae View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2023

  1. Merge branch 'main' into mining-options-refactor

    @macfarla
    macfarla authored Oct 20, 2023
    Configuration menu
    Copy the full SHA
    16315a4 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2023

  1. Merge branch 'mining-options-refactor' of github.com:fab-10/besu into… 

    … mining-options-refactor
    @fab-10
    fab-10 committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    2700930 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
    @fab-10
    fab-10 committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    e55392b View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2023

  1. Merge branch 'main' into mining-options-refactor

    @fab-10
    fab-10 committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    d710e5c View commit details
    Browse the repository at this point in the history

  2. Update besu/src/main/java/org/hyperledger/besu/cli/BesuCommand.java 

    [skip-ci]

Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
    @fab-10 @macfarla
    fab-10 and macfarla authored Oct 24, 2023
    Configuration menu
    Copy the full SHA
    639af82 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'mining-options-refactor' of github.com:fab-10/besu into… 

    … mining-options-refactor
    @fab-10
    fab-10 committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    232caa6 View commit details
    Browse the repository at this point in the history