-
Notifications
You must be signed in to change notification settings - Fork 820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix BFT creating invalid blocks on London when zero base fee is used #5276
Conversation
Signed-off-by: Jason Frame <jason.frame@consensys.net>
|
Signed-off-by: Jason Frame <jason.frame@consensys.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Jason Frame <jason.frame@consensys.net>
I wasn't able to run the full suite of tests. A lot failed due to docker issues. Was able to run the BFT ATs though except the PKI ones which are failing due to lib issue (probably mac related) |
…n them locally Signed-off-by: Jason Frame <jason.frame@consensys.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…can't run them locally" This reverts commit ef4c4a7. Signed-off-by: Jason Frame <jason.frame@consensys.net>
…yperledger#5276) Signed-off-by: Jason Frame <jason.frame@consensys.net>
…yperledger#5276) Signed-off-by: Jason Frame <jason.frame@consensys.net>
PR description
This fixes an issue where on IBFT and QBFT invalid blocks are created by the proposer when using London with a zeroBaseFee.
The cause of this is that the ZeroBaseFeeMarket was returning true for the implementsDataFee check which meant that the excessDataGas field was added to the block header. This is only valid after Shanghai.
Fixed Issue(s)
fixes #5270