Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow comments in Genesis JSON file. #49

Merged

Conversation

AbdelStark
Copy link
Contributor

@AbdelStark AbdelStark commented Sep 25, 2019

PR description

Disallow comments in Genesis JSON file.

Fixed Issue(s)

fixes PAN-3013

Signed-off-by: Abdelhamid Bakhta abdelhamid.bakhta@consensys.net

EdJoJob and others added 5 commits September 24, 2019 09:02
Signed-off-by: Edward Evans <edward.joshua.evans@gmail.com>
Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net>
Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net>
Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net>
Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net>
Signed-off-by: Abdelhamid Bakhta <abdelhamid.bakhta@consensys.net>
@AbdelStark AbdelStark added the enhancement New feature or request label Sep 25, 2019
Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@AbdelStark AbdelStark merged commit 231cd71 into hyperledger:master Sep 25, 2019
@AbdelStark AbdelStark deleted the feature/disallow-comments-genesis branch September 25, 2019 08:05
@amsmota amsmota mentioned this pull request Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants