Add Diego López León to maintainers #3054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com>
macfarla
approved these changes
Nov 14, 2021
daniellehrner
approved these changes
Nov 14, 2021
taccatisid
approved these changes
Nov 15, 2021
jflo
approved these changes
Nov 15, 2021
lucassaldanha
approved these changes
Nov 15, 2021
|
Hey! Thanks @atoulme for the proposal and thanks to everyone who voted for their trust in me. I am more than happy to take on the responsibilities associated with this role. |
pinges
approved these changes
Nov 15, 2021
jframe
approved these changes
Nov 17, 2021
antonydenyer
approved these changes
Nov 17, 2021
matkt
approved these changes
Nov 17, 2021
shemnon
approved these changes
Nov 21, 2021
jflo
approved these changes
Nov 22, 2021
sajz
approved these changes
Nov 22, 2021
|
This PR has met the more than 50% threshold, merging it ahead of the 2 week cutoff. Congrats @diega 🥳 |
|
Did you actually commit the change @garyschulte ? |
|
I set it to automerge 🤔
…On Tue, Nov 23, 2021, 12:58 PM Antoine Toulme ***@***.***> wrote:
Did you actually commit the change @garyschulte
<https://github.com/garyschulte> ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3054 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJOL4ATK6WQZ65NNC3CK2LUNP567ANCNFSM5H5V7OZQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
|
Kudos, SonarCloud Quality Gate passed!
|
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
Nov 30, 2021
Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com> Co-authored-by: garyschulte <garyschulte@gmail.com> Co-authored-by: Sally MacFarlane <sally.macfarlane@consensys.net>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
Signed-off-by: Antoine Toulme <antoine@lunar-ocean.com> Co-authored-by: garyschulte <garyschulte@gmail.com> Co-authored-by: Sally MacFarlane <sally.macfarlane@consensys.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Antoine Toulme antoine@lunar-ocean.com
PR description
Diego has made significant commits improving the quality and features of besu, this PR adds him as a maintainer.
Voting ends 2 weeks from the publication of this PR or once a majority of the maintainers vote.
For more information on this process see the Becoming a Maintainer section in the MAINTAINERS.md file.
Fixed Issue(s)
Changelog