Fix Gradle 7.0 compatibility issues and build warnings #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes as many Gradle 7.0 compatibility issues as possible * `baseName` -> `archiveBaseName` * `extension` -> `archiveExtension` * `destinationDir` -> `destinationDirectory` * `runtime` -> `runtimeOnly` * Change some log4j-api and log4j-core dependencies * Remove an unneeded and outdated plugin (`net.ltgt.apt`) * tweak the plugin-api change detector's property annotations. Warnings still exist with one external plugin used for license file checking that we do not control the soruce code for. Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
CjHare
reviewed
Jan 6, 2020
| 'Implementation-Version': calculateVersion() | ||
| ) | ||
| } | ||
| } | ||
|
|
||
| dependencies { | ||
| api 'org.apache.logging.log4j:log4j-api' |
There was a problem hiding this comment.
Interesting, is the reason for promoting from implementation to api due to a Log4j-api class being in one of the signatures of the util classes, or Gradle 7.0?
There was a problem hiding this comment.
They are getting rid of the runtime dependency type, and runtimeOnly excludes the dependent types from compilation visibility. i.e. runtime was api + runtimeOnly. This seemed cleaner than adding log4j2 dependencies in 10 or so new build files.
There was a problem hiding this comment.
This seemed cleaner than adding log4j2 dependencies in 10 or so new build files.
True.
Log4j-api is used in pretty much every submodule (due to the fine amount of Besu logging) and could be considered a kind of common dependency 🤔
Being unique in that respect, I can see the value in having as an api dependency 👍
CjHare
approved these changes
Jan 9, 2020
edwardmack
pushed a commit
to ChainSafe/besu
that referenced
this pull request
Feb 4, 2020
Removes as many Gradle 7.0 compatibility issues as possible * `baseName` -> `archiveBaseName` * `extension` -> `archiveExtension` * `destinationDir` -> `destinationDirectory` * `runtime` -> `runtimeOnly` * Change some log4j-api and log4j-core dependencies * Remove an unneeded and outdated plugin (`net.ltgt.apt`) * tweak the plugin-api change detector's property annotations. Warnings still exist with one external plugin used for license file checking that we do not control the source code for. Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com>
edwardmack
pushed a commit
to ChainSafe/besu
that referenced
this pull request
Feb 4, 2020
Removes as many Gradle 7.0 compatibility issues as possible * `baseName` -> `archiveBaseName` * `extension` -> `archiveExtension` * `destinationDir` -> `destinationDirectory` * `runtime` -> `runtimeOnly` * Change some log4j-api and log4j-core dependencies * Remove an unneeded and outdated plugin (`net.ltgt.apt`) * tweak the plugin-api change detector's property annotations. Warnings still exist with one external plugin used for license file checking that we do not control the source code for. Signed-off-by: Danno Ferrin <danno.ferrin@gmail.com> Signed-off-by: edwardmack <ed@edwardmack.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes as many Gradle 7.0 compatibility issues as possible
baseName->archiveBaseNameextension->archiveExtensiondestinationDir->destinationDirectoryruntime->runtimeOnlynet.ltgt.apt)Warnings still exist with one external plugin used for license file
checking that we do not control the soruce code for.
Signed-off-by: Danno Ferrin danno.ferrin@gmail.com