GoQuorum ATs: run the estimate gas test #2294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
macfarla
changed the title
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
…)" This reverts commit 3627662. Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
mark-terry
reviewed
May 20, 2021
| // It is possible to have a data field that has a lower intrinsic value than the PTM hash | ||
| // so this checks the tx as if we were to place a PTM hash (with all non-zero values). | ||
| // This means a potential over-estimate of gas, rather than the exact cost to run right now. | ||
| final Bytes payload = |
There was a problem hiding this comment.
yeah this PR is reverting my previous one
| @@ -198,6 +179,10 @@ public TransactionSimulator( | |||
|
|
|||
| final Transaction transaction = transactionBuilder.build(); | |||
|
|
|||
| final ProtocolSpec protocolSpec = protocolSchedule.getByBlockNumber(header.getNumber()); | |||
|
|
|||
| final MainnetTransactionProcessor transactionProcessor = | |||
There was a problem hiding this comment.
What's the impact of moving this from before, to after the transaction is built?
There was a problem hiding this comment.
no impact. I can move it back
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
* run the estimate gas test * Revert "Modify Gas estimation logic for GoQuorum mode (hyperledger#2282)" This reverts commit 3627662. Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net> Co-authored-by: mark-terry <36909937+mark-terry@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sally MacFarlane sally.macfarlane@consensys.net
Revert #2282
Enabling one more passing GoQuorum AT
See #2282
Changelog