Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Estimate gas: ignore nonce #2133

Merged
merged 3 commits into from
Apr 12, 2021

Conversation

macfarla
Copy link
Contributor

Ignore nonce when supplied to eth_estimateGas or eth_call. This is to better support web3j calls as per #2125

Changelog

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
Copy link
Contributor

@pinges pinges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@macfarla macfarla merged commit 8284758 into hyperledger:master Apr 12, 2021
@macfarla macfarla deleted the estimategas-ignore-nonce branch April 12, 2021 23:53
eum602 pushed a commit to lacchain/besu that referenced this pull request Nov 3, 2023
* jsonignore

Signed-off-by: Sally MacFarlane <sally.macfarlane@consensys.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants