-
Notifications
You must be signed in to change notification settings - Fork 864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"container-tests" module. #1894
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mark-terry
force-pushed
the
container-tests
branch
2 times, most recently
from
February 9, 2021 22:46
ed221a4
to
876aae9
Compare
macfarla
reviewed
Feb 10, 2021
container-tests/tests/src/test/resources/testcontainers/goQuorum/qdata/geth/chaindata/LOG
Outdated
Show resolved
Hide resolved
pinges
reviewed
Feb 10, 2021
container-tests/tests/src/test/resources/testcontainers/goQuorum/qdata/geth/chaindata/CURRENT
Outdated
Show resolved
Hide resolved
mark-terry
force-pushed
the
container-tests
branch
from
February 25, 2021 14:15
bc2dcac
to
ac84bae
Compare
Signed-off-by: Mark Terry <mark.terry@consensys.net>
mark-terry
force-pushed
the
container-tests
branch
from
March 30, 2021 12:31
85e3492
to
43044b3
Compare
Signed-off-by: Mark Terry <mark.terry@consensys.net>
Signed-off-by: Mark Terry <mark.terry@consensys.net>
Signed-off-by: Mark Terry <mark.terry@consensys.net>
Signed-off-by: Mark Terry <mark.terry@consensys.net>
Signed-off-by: Mark Terry <mark.terry@consensys.net>
usmansaleem
reviewed
Apr 1, 2021
usmansaleem
reviewed
Apr 1, 2021
Signed-off-by: Mark Terry <mark.terry@consensys.net>
Signed-off-by: Mark Terry <mark.terry@consensys.net>
macfarla
reviewed
Apr 6, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good overall
container-tests/tests/src/test/java/org/hyperledger/besu/tests/container/ContainerTestBase.java
Outdated
Show resolved
Hide resolved
macfarla
approved these changes
Apr 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
Signed-off-by: Mark Terry <mark.terry@consensys.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Adds a new "container-tests" module, with a 2 node private network (besu/tessera, GoQuorum/tessera) running.
Fixed Issue(s)
Changelog