-
Notifications
You must be signed in to change notification settings - Fork 863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add David Mechler to maintainers #1267
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ratan Rai Sur <ratan.r.sur@gmail.com>
RatanRSur
force-pushed
the
RatanRSur-patch-1
branch
from
July 28, 2020 18:13
371e100
to
f3a456c
Compare
lucassaldanha
approved these changes
Jul 28, 2020
NicolasMassart
approved these changes
Jul 28, 2020
joshuafernandes
approved these changes
Jul 28, 2020
ajsutton
approved these changes
Jul 28, 2020
pinges
approved these changes
Jul 29, 2020
macfarla
approved these changes
Jul 29, 2020
MadelineMurray
approved these changes
Jul 29, 2020
timbeiko
approved these changes
Jul 30, 2020
shemnon
approved these changes
Jul 30, 2020
AbdelStark
approved these changes
Jul 30, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
LGTM |
matkt
approved these changes
Aug 4, 2020
edwardmack
approved these changes
Aug 4, 2020
Edward makes 12, which is an absolute majority. If there is no objection I will close this in 24 hours time. |
rain-on
approved these changes
Aug 4, 2020
jframe
approved these changes
Aug 5, 2020
atoulme
approved these changes
Aug 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
David has provided significant PRs that have improved the quality of besu.
Voting ends 2 weeks from the publication of this PR.
For more information on this process see the Becoming a Maintainer section in the MAINTAINERS.md file.