Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PeerReputation - timeouts are indexed by request code which does not take into account protocol #6869

Open
macfarla opened this issue Apr 3, 2024 · 1 comment
Labels
peering snack Smaller coding task - less than a day for an experienced dev

Comments

@macfarla
Copy link
Contributor

macfarla commented Apr 3, 2024

Fix - either index by protocol as well as message code - or don't track timeouts per request type at all (simplify) - what is it giving us to track them separately?

ie eth message code 1 and snap message code 1 would both end up counted together

  public Map<Integer, AtomicInteger> timeoutCounts() {
    return timeoutCountByRequestType;
  }

log does not mention protocol but this is snap

2024-04-02 14:47:51.725+10:00 | EthScheduler-Timer-0 | DEBUG | PeerReputation | Disconnection triggered by 3 repeated timeouts for requestCode 1
2024-04-02 14:47:51.725+10:00 | EthScheduler-Timer-0 | DEBUG | EthPeers | Disconnected EthPeer 0xcfe6f6424d1f2255...
@jframe jframe added peering snack Smaller coding task - less than a day for an experienced dev labels Apr 3, 2024
@pr9t
Copy link
Contributor

pr9t commented Sep 13, 2024

Hey, I am interested in this issue. Please assign this to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
peering snack Smaller coding task - less than a day for an experienced dev
Projects
None yet
Development

No branches or pull requests

3 participants