Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KZG Precompile to BigEndian #5485

Closed
jflo opened this issue May 23, 2023 · 1 comment
Closed

KZG Precompile to BigEndian #5485

jflo opened this issue May 23, 2023 · 1 comment
Labels
TeamChupa GH issues worked on by Chupacabara Team TeamRevenant GH issues worked on by Revenant Team

Comments

@jflo
Copy link
Contributor

jflo commented May 23, 2023

The Consensus Layer has agreed to send kzg commitments in big endian for consistency:

ethereum/consensus-specs#3354
Once this pr for the KZG library is merged and released: ethereum/c-kzg-4844#305

We need to update the KZG library, and make sure that the KZGPrecompile works correctly. Since we just pass whatever the CL sends us down to the library, this should "just work" but at the very least new test vectors need to be added to work with the updated library.
@jflo jflo added the TeamChupa GH issues worked on by Chupacabara Team label May 23, 2023
@jflo jflo mentioned this issue May 23, 2023
Closed
22 tasks
@non-fungible-nelson non-fungible-nelson added the TeamRevenant GH issues worked on by Revenant Team label May 30, 2023
@non-fungible-nelson
Copy link
Contributor

Completed in #5536

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
TeamChupa GH issues worked on by Chupacabara Team TeamRevenant GH issues worked on by Revenant Team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jflo @non-fungible-nelson