From 9a4c6b85b061e00a515dc8e4853ba168c111a309 Mon Sep 17 00:00:00 2001 From: Matthew Whitehead Date: Wed, 9 Oct 2024 10:48:34 +0100 Subject: [PATCH] Metric should be a gauge not a counter Signed-off-by: Matthew Whitehead --- .../diffbased/bonsai/worldview/BonsaiArchiver.java | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/ethereum/core/src/main/java/org/hyperledger/besu/ethereum/trie/diffbased/bonsai/worldview/BonsaiArchiver.java b/ethereum/core/src/main/java/org/hyperledger/besu/ethereum/trie/diffbased/bonsai/worldview/BonsaiArchiver.java index 47e62185da7..ea8e4fa17e0 100644 --- a/ethereum/core/src/main/java/org/hyperledger/besu/ethereum/trie/diffbased/bonsai/worldview/BonsaiArchiver.java +++ b/ethereum/core/src/main/java/org/hyperledger/besu/ethereum/trie/diffbased/bonsai/worldview/BonsaiArchiver.java @@ -22,7 +22,6 @@ import org.hyperledger.besu.ethereum.trie.diffbased.common.trielog.TrieLogManager; import org.hyperledger.besu.metrics.BesuMetricCategory; import org.hyperledger.besu.plugin.services.MetricsSystem; -import org.hyperledger.besu.plugin.services.metrics.Counter; import org.hyperledger.besu.plugin.services.trielogs.TrieLog; import java.util.Optional; @@ -56,7 +55,6 @@ public class BonsaiArchiver implements BlockAddedObserver { private static final int DISTANCE_FROM_HEAD_BEFORE_ARCHIVING_OLD_STATE = 10; private final TrieLogManager trieLogManager; protected final MetricsSystem metricsSystem; - protected final Counter archivedBlocksCounter; // For logging progress. Saves doing a DB read just to record our progress final AtomicLong latestArchivedBlock = new AtomicLong(0); @@ -73,11 +71,11 @@ public BonsaiArchiver( this.trieLogManager = trieLogManager; this.metricsSystem = metricsSystem; - archivedBlocksCounter = - metricsSystem.createCounter( - BesuMetricCategory.BLOCKCHAIN, - "archived_blocks_state_total", - "Total number of blocks for which state has been archived"); + metricsSystem.createLongGauge( + BesuMetricCategory.BLOCKCHAIN, + "archived_blocks_state_total", + "Total number of blocks for which state has been archived", + () -> latestArchivedBlock.get()); } public void initialize() {