Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BBS] optional docker build and images #3104

Closed
amanji opened this issue Jul 16, 2024 · 2 comments
Closed

[BBS] optional docker build and images #3104

amanji opened this issue Jul 16, 2024 · 2 comments
Assignees

Comments

@amanji
Copy link
Contributor

amanji commented Jul 16, 2024

The currently included BBS (ursa-bbs-signatures) library relies on an outdated and archived rust library and does not support Apple ARM architecture. It is also an optional dependency at the moment but is installed by default. It was previously proposed to move the BBS implementation from the core of ACA-Py to a plugin, however this would be a significant undertaking for a deprecated library and given the fact that there is an updated spec for BBS signatures whose implementation is imminent.

Instead, it is currently proposed that 2 separate ACA-Py images be built going forward. The default image would not have BBS installed. An extended image would be available (tagged with a -bbs suffix) that includes BBS (for those that need it) with the understanding that it would not support Apple ARM architecture.

This ticket encompasses the following deliverables:

  1. Remove BBS dependency from the current Docker config.
  2. Create a Docker.bbs config file that creates an augmented ACA-Py image which includes BBS (to be tagged with a -bbs suffix)
  3. README documentation explaining the different images and the trade-offs of both
  4. Release both images for consumption
@swcurran
Copy link
Member

Looks good!

@jamshale
Copy link
Contributor

jamshale commented Aug 1, 2024

Closing as completed

@jamshale jamshale closed this as completed Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants