Skip to content

Conversation

@sophia1ch
Copy link
Contributor

This PR reverts the removal of secondary settling to reduce transaction fees.

Signed-off-by: sophia <sophia.koehler@stud.tu-darmstadt.de>
This reverts commit fe3c63f.

Signed-off-by: sophia <sophia.koehler@stud.tu-darmstadt.de>
…ing that uses the AdjudicatorReq object during conclusion of a channel. Also remove functions that are necessary for the Secondary option."

This reverts commit 1188366.

Signed-off-by: sophia <sophia.koehler@stud.tu-darmstadt.de>
This reverts commit 7600a7a.

Signed-off-by: sophia <sophia.koehler@stud.tu-darmstadt.de>
Signed-off-by: sophia <sophia.koehler@stud.tu-darmstadt.de>
@sophia1ch sophia1ch force-pushed the include-settle-secondary branch from 906b8e2 to e978fd9 Compare February 19, 2024 12:04
Signed-off-by: sophia1ch <sophia.koehler@outlook.com>
@sophia1ch sophia1ch marked this pull request as ready for review February 20, 2024 08:58
@iljabvh iljabvh self-requested a review February 20, 2024 15:14
Copy link
Contributor

@iljabvh iljabvh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR reverts the changes that removed the option to wait for a peer to conclude the channel. It restores the ability to wait for a specified number of blocks until the channel peer has called concludeFinal.

@iljabvh iljabvh merged commit 44adf86 into hyperledger-labs:main Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants