🐛 [channel/machine, client] Sub-channel withdrawal without regist… #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I dont quite get the change. |
|
It affects all channels. The situation after the change is not perfect. But it is better than before. In the long run, we could reconsider our machine logic as a whole. |
Ok. After your change it is not possible anymore to |
ggwpez
previously approved these changes
May 4, 2021
ggwpez
force-pushed
the
58-subchannel-withdrawal
branch
from
ce401fc to
1e817ee
Compare
The current implementation required a sub-channel to be registered on-chain before it could be withdrawn. However, in the optimistic case, a sub-channel should be withdrawable into its parent channel without blockchain interaction. We achieve this by modifying the state machine to allow for a transition from phase final to phase withdrawing. Signed-off-by: Matthias Geihs <matthias@perun.network>
ggwpez
force-pushed
the
58-subchannel-withdrawal
branch
from
1e817ee to
0ca21aa
Compare
ggwpez
approved these changes
May 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ering
The current implementation required a sub-channel to be registered on-chain before it could be withdrawn.
However, in the optimistic case, a sub-channel should be withdrawable into its parent channel without
blockchain interaction. We achieve this by modifying the state machine to allow for a transition from
phase final to phase withdrawing.
Signed-off-by: Matthias Geihs matthias@perun.network
Closes #58