Fix Multi-Adjudicator Subscription #366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Philipp-Florens Lehwalder <philipp@perun.network>
Signed-off-by: Philipp-Florens Lehwalder <philipp@perun.network>
Before, the for loop would continue forever, causing zombie go routines. Now, the for loop is escaped if the subscription is closed. Signed-off-by: Matthias Geihs <matthias@perun.network>
matthiasgeihs
approved these changes
Aug 1, 2022
Contributor
matthiasgeihs
left a comment
matthiasgeihs
left a comment
There was a problem hiding this comment.
I added a commit that ensures that the for loop will return when the subscription is closed. Please have a look. Otherwise looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #365.