Fix funder timeout tests #310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RmbRT
added
bug
RmbRT
force-pushed
the
fix-funder-timeout-tests
branch
2 times, most recently
from
b4db420 to
2d534a4
Compare
Contributor
|
Can you insert a link to a pipeline failing because of this? |
Contributor
Author
I don't have a link, sorry. The problem was that the funder sometimes failed to properly report all failed fundings, instead, it returned an error that the context was closed, as a subscription error. Since the tests expect that all missing assets are reported in the error, the tests sometimes failed. |
matthiasgeihs
previously approved these changes
Feb 2, 2022
RmbRT
force-pushed
the
fix-funder-timeout-tests
branch
from
2d534a4 to
7e230cd
Compare
matthiasgeihs
previously approved these changes
Feb 2, 2022
RmbRT
force-pushed
the
fix-funder-timeout-tests
branch
from
7e230cd to
ed4e778
Compare
matthiasgeihs
previously approved these changes
Feb 2, 2022
Signed-off-by: Steffen Rattay <steffen@perun.network>
Signed-off-by: Steffen Rattay <steffen@perun.network>
RmbRT
force-pushed
the
fix-funder-timeout-tests
branch
from
bad0318 to
fac15d8
Compare
matthiasgeihs
approved these changes
Feb 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestFunding_PeerTimeoutfailed sometimes, this was due to an event race in the logic of the funder'swaitForFundingConfirmationfunction: it was handling the same context'sDone()event in two differentselectbranches.In this MR, I properly prioritize the
selectbranches so that the race is resolved.