🚸 Allocation helpers

[matthiasgeihs]

Goal: Make Allocation easier to setup and modify.

Closes #63

[matthiasgeihs]

@manoranjith @ggwpez What do you think?

[matthiasgeihs]

Rebase

[ggwpez]

@matthiasgeihs

[manoranjith]

@matthiasgeihs Overall the changes LGTM. I like the helper functions to create and modify allocations.

I have a couple of questions:

1. What is the advantage of defining an AssetIdx type over directly using uint16 ?
2. Are changes that change the type Alias to type Def related to this addition of helper functions ? If not, could we move it to a different PR ?

[matthiasgeihs]

@matthiasgeihs Overall the changes LGTM. I like the helper functions to create and modify allocations.

I have a couple of questions:

1. What is the advantage of defining an AssetIdx type over directly using uint16 ?
2. Are changes that change the type Alias to type Def related to this addition of helper functions ? If not, could we move it to a different PR ?

Thanks for your comments.

1. There are some historical reasons why I introduced a separate type for an asset index. However, these apply no more and I removed the type again. See 🚸 Allocation helpers #240 (comment) for more details.
2. Yes, changing the alias to a def is not inherently related with this PR. However, it is loosely related and it would generate additional effort to pull that apart now, so I prefer to keep it here. I appreciate your comment nevertheless and we should all take into account that we rather create clean separate PRs for separate issues whenever possible.

[matthiasgeihs]

@ggwpez Please have another look. All comments addressed. Need to still squash and probably rebase.

[manoranjith]

LGTM.

[matthiasgeihs]

Rebase

[ggwpez]

Rebase

Could you also squash? An approval now will be discarded anyway.
@matthiasgeihs