Skip to content

Conversation

@matthiasgeihs
Copy link
Contributor

Function FromEthState did not set the App correctly on a decoded state.

Relates to #226

Function `FromEthState` did not set the App correctly on a decoded state.

Signed-off-by: Matthias Geihs <matthias@perun.network>
Copy link
Contributor

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue #226 explicitly mentions to add a test for ToEthState and FromEthState.
I would then move that to a new issue and merge this as hotfix.

PS: Just now realized that you used "Relates to" instead of "Closes", all fine 👍

@ggwpez ggwpez merged commit 9d65efa into hyperledger-labs:dev Sep 28, 2021
@ggwpez ggwpez deleted the fix/state-app-decoding branch September 28, 2021 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants