Skip to content

💥 [backend/eth/channel] Remove validation of adj in validateAssettHolder #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

manoranjith
Copy link

  • Contract code at adjudicator address is not validated because, the
    it is passed by the caller, hence it is the responsibility of the
    caller to provide a valid address.

Resolves #109.

Copy link
Contributor

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Just some comments about spelling. There is a superfluous the in the commit message btw.

- Contract code at the adjudicator address is not validated, because it
  is passed by the caller and it is the caller's responsibility to
  provide a valid address.

Resolves hyperledger-labs#109.

Signed-off-by: Manoranjith <ponraj.manoranjitha@in.bosch.com>
@manoranjith manoranjith force-pushed the 109-validate-asset-does-not-validate-adjudicator branch from 9372537 to bebf936 Compare June 16, 2021 19:32
@manoranjith manoranjith requested a review from ggwpez June 16, 2021 19:32
@manoranjith
Copy link
Author

@ggwpez I have update the comments and also revised the commit message.

Copy link
Contributor

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ggwpez ggwpez merged commit 7eaa521 into hyperledger-labs:dev Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validate asset holder function should not valid adjudicator contract.
2 participants