Context check: Fix client

Signed-off-by: Matthias Geihs <matthias@perun.network>

Author: matthiasgeihs

client/proposal.go

@@ -165,8 +165,10 @@ func (c *Client) ProposeChannel(ctx context.Context, prop ChannelProposal) (*Cha
 	}
 
 	// 2. send proposal, wait for response, create channel object
-	c.enableVer1Cache()        // cache version 1 updates until channel is opened
-	defer c.releaseVer1Cache() // replay cached version 1 updates
+	// cache version 1 updates until channel is opened
+	c.enableVer1Cache()
+	// replay cached version 1 updates
+	defer c.releaseVer1Cache() //nolint:contextcheck
 	ch, err := c.proposeTwoPartyChannel(ctx, prop)
 	if err != nil {
 		return nil, errors.WithMessage(err, "channel proposal")
@@ -236,8 +238,10 @@ func (c *Client) handleChannelProposalAcc(
 		return ch, errors.WithMessage(err, "validating channel proposal acceptance")
 	}
 
-	c.enableVer1Cache()        // cache version 1 updates
-	defer c.releaseVer1Cache() // replay cached version 1 updates
+	// cache version 1 updates
+	c.enableVer1Cache()
+	// replay cached version 1 updates
+	defer c.releaseVer1Cache() //nolint:contextcheck
 
 	if ch, err = c.acceptChannelProposal(ctx, prop, p, acc); err != nil {
 		return ch, errors.WithMessage(err, "accept channel proposal")
@@ -700,7 +704,7 @@ func (c *Client) releaseVer1Cache() {
 
 	c.version1Cache.enabled--
 	for _, u := range c.version1Cache.cache {
-		go c.handleChannelUpdate(u.uh, u.p, u.m)
+		go c.handleChannelUpdate(u.uh, u.p, u.m) //nolint:contextcheck
 	}
 	c.version1Cache.cache = nil
 }

client/update.go

@@ -41,7 +41,7 @@ func (c *Client) handleChannelUpdate(uh UpdateHandler, p wire.Address, m Channel
 		return
 	}
 	pidx := ch.Idx() ^ 1
-	ch.handleUpdateReq(pidx, m, uh)
+	ch.handleUpdateReq(pidx, m, uh) //nolint:contextcheck
 }
 
 func (c *Client) cacheVersion1Update(uh UpdateHandler, p wire.Address, m ChannelUpdateProposal) bool {
@@ -288,12 +288,12 @@ func (c *Channel) handleUpdateReq(
 	client := c.client
 
 	if prop, ok := req.(*virtualChannelFundingProposal); ok {
-		client.handleVirtualChannelFundingProposal(c, prop, responder)
+		client.handleVirtualChannelFundingProposal(c, prop, responder) //nolint:contextcheck
 		return
 	}
 
 	if prop, ok := req.(*virtualChannelSettlementProposal); ok {
-		client.handleVirtualChannelSettlementProposal(c, prop, responder)
+		client.handleVirtualChannelSettlementProposal(c, prop, responder) //nolint:contextcheck
 		return
 	}
 

client/virtual_channel.go

@@ -90,18 +90,18 @@ func (c *Client) handleVirtualChannelFundingProposal(
 ) {
 	err := c.validateVirtualChannelFundingProposal(ch, prop)
 	if err != nil {
-		c.rejectProposal(responder, err.Error())
+		c.rejectProposal(responder, err.Error()) //nolint:contextcheck
 	}
 
 	ctx, cancel := context.WithTimeout(c.Ctx(), virtualFundingTimeout)
 	defer cancel()
 
 	err = c.fundingWatcher.Await(ctx, prop)
 	if err != nil {
-		c.rejectProposal(responder, err.Error())
+		c.rejectProposal(responder, err.Error()) //nolint:contextcheck
 	}
 
-	c.acceptProposal(responder)
+	c.acceptProposal(responder) //nolint:contextcheck
 }
 
 func (c *Channel) watchVirtual() error {
@@ -348,7 +348,7 @@ func (c *Client) matchFundingProposal(ctx context.Context, a, b interface{}) boo
 	}
 
 	go func() {
-		err := virtual.watchVirtual()
+		err := virtual.watchVirtual() //nolint:contextcheck // The context will be derived from the channel context.
 		c.log.Debugf("channel %v: watcher stopped: %v", virtual.ID(), err)
 	}()
 	return true

client/virtual_channel_settlement.go

@@ -79,7 +79,7 @@ func (c *Client) handleVirtualChannelSettlementProposal(
 ) {
 	err := c.validateVirtualChannelSettlementProposal(parent, prop)
 	if err != nil {
-		c.rejectProposal(responder, err.Error())
+		c.rejectProposal(responder, err.Error()) //nolint:contextcheck
 	}
 
 	ctx, cancel := context.WithTimeout(c.Ctx(), virtualSettlementTimeout)
@@ -90,7 +90,7 @@ func (c *Client) handleVirtualChannelSettlementProposal(
 		resp: responder,
 	})
 	if err != nil {
-		c.rejectProposal(responder, err.Error())
+		c.rejectProposal(responder, err.Error()) //nolint:contextcheck
 	}
 }