Feat: Add check for unique chaincode names (#596)

Author: OsamaRab3

e2e/fabloCommands.test.ts

@@ -182,6 +182,47 @@ describe("extend config", () => {
     expect(commandResult).toEqual(TestCommands.failure());
     expect(commandResult.output).toContain("commands-tests/fablo-config.json does not exist\n");
   });
+
+  it("should throw an error for duplicate chaincode names across different channels", () => {
+    // Given
+    commands.fabloExec("init");
+    const configPath = `${commands.workdir}/fablo-config.json`;
+    // const config = JSON.parse(fs.readFileSync(configPath, "utf8")) as FabloConfigJson;
+    const config = JSON.parse(commands.getFileContent("fablo-config.json")) as FabloConfigJson;
+
+    config.channels.push({
+      name: "my-channel2",
+      orgs: [{ name: "Org1", peers: ["peer0"] }],
+    });
+
+    config.chaincodes.push(
+      {
+        name: "chaincode1",
+        version: "1.0",
+        channel: "my-channel",
+        lang: "node",
+        directory: "./samples/chaincodes/chaincode-kv-node",
+        privateData: [],
+      },
+      {
+        name: "chaincode1",
+        version: "1.0",
+        channel: "my-channel2",
+        lang: "node",
+        directory: "./samples/chaincodes/chaincode-kv-node",
+        privateData: [],
+      },
+    );
+
+    fs.writeFileSync(configPath, JSON.stringify(config, null, 2));
+
+    // When
+    const commandResult = commands.fabloExec("validate", true);
+
+    // Then
+    expect(commandResult.output).toContain("Chaincode name 'chaincode1' is not unique");
+    expect(commandResult.output).toContain("Validation errors count: 1");
+  });
 });
 
 describe("version", () => {

samples/fablo-config-hlf2-2orgs-2chaincodes-private-data.yaml

@@ -55,4 +55,4 @@ chaincodes:
       - name: both-orgs-collection
         orgNames:
           - Org1
-          - Org2
+          - Org2

src/extend-config/extendChaincodesConfig.ts

@@ -37,11 +37,31 @@ const createPrivateCollectionConfig = (
   };
 };
 
+const checkUniqueChaincodeNames = (allChannelsConfig: any): void => {
+  const chaincodeNames = new Set<string>();
+
+  const allChaincodes: ChaincodeJson[] = [];
+
+  Object.values(allChannelsConfig.channels || {}).forEach((channel: any) => {
+    if (channel.chaincodes) {
+      allChaincodes.push(...channel.chaincodes);
+    }
+  });
+
+  allChaincodes.forEach((chaincode) => {
+    if (chaincodeNames.has(chaincode.name)) {
+      throw new Error(`Chaincode name '${chaincode.name}' is not unique across channels.`);
+    }
+    chaincodeNames.add(chaincode.name);
+  });
+};
+
 const extendChaincodesConfig = (
   chaincodes: ChaincodeJson[],
   transformedChannels: ChannelConfig[],
   network: Global,
 ): ChaincodeConfig[] => {
+  checkUniqueChaincodeNames(chaincodes);
   return chaincodes.map((chaincode, index) => {
     const channel = transformedChannels.find((c) => c.name === chaincode.channel);
     if (!channel) throw new Error(`No matching channel with name '${chaincode.channel}'`);

src/extend-config/extendConfig.ts

@@ -4,6 +4,7 @@ import { extendOrgsConfig } from "./extendOrgsConfig";
 import extendGlobal from "./extendGlobal";
 import extendChannelsConfig from "./extendChannelsConfig";
 import extendChaincodesConfig from "./extendChaincodesConfig";
+import checkUniqueChaincodeNames from "./extendChaincodesConfig";
 import extendHooksConfig from "./extendHooksConfig";
 import { distinctOrdererHeads, mergeOrdererGroups } from "./mergeOrdererGroups";
 
@@ -22,6 +23,7 @@ const extendConfig = (json: FabloConfigJson): FabloConfigExtended => {
   const orderedHeadsDistinct = distinctOrdererHeads(ordererGroups);
 
   const channels = extendChannelsConfig(channelsJson, orgs, ordererGroups);
+  checkUniqueChaincodeNames(chaincodesJson, channels, global);
   const chaincodes = extendChaincodesConfig(chaincodesJson, channels, global);
   const hooks = extendHooksConfig(hooksJson);