Stop validating agent lists #713
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When serializers validate data, it compares them with the existing data in the DB for unique columns. Since agent lists are extracted from the DB, such validations will fail definitely. Thus, for getting data, the agent list in the response will skip for validation. Signed-off-by: dodo920306 <dodo920306@gmail.com>
YoungHypo
approved these changes
Jul 15, 2025
|
I want to figure out something first, so please don't merge this. |
|
@yeasy @YoungHypo Should agents actually be allowed to have the same name? |
|
Agents will be in different namespaces based on the org. So one org cannot have two agents with the same name. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When serializers validate data, it compares them with the existing data in the DB for unique columns. Since agent lists are extracted from the DB, such validations will fail definitely. Thus, for getting data, the agent list in the response will skip for validation.