Allow generation of Identifier field in Playground if no validation needed #2521
Conversation
| @@ -174,6 +175,7 @@ describe('ResourceComponent', () => { | |||
| describe('#generateResource', () => { | |||
| let mockClassDeclaration; | |||
| let mockModelFile; | |||
| let mockValidator; | |||
| it('should generate a valid resource with an empty ID', () => { | ||
| let mockField = { | ||
| getValidator: () => { | ||
| return true; |
There was a problem hiding this comment.
Should return a String?
| return true; | ||
| } | ||
| }; | ||
| mockClassDeclaration.getOwnProperty.returns(mockField); |
There was a problem hiding this comment.
You know the identifier field name (in the beforeEach) so might be worth pulling that out to a variable and using mockClassDeclaration.getOwnProperty.calledWith(idFieldName).returns(mockField);. This is saying that all field names exist and return the same mock, but maybe that's OK.
| return false; | ||
| } | ||
| }; | ||
| mockClassDeclaration.getOwnProperty.returns(mockField); |
There was a problem hiding this comment.
Same comment as above.
| return false; | ||
| } | ||
| }; | ||
| mockClassDeclaration.getOwnProperty.returns(mockField); |
There was a problem hiding this comment.
Same comment as above.
| return false; | ||
| } | ||
| }; | ||
| mockClassDeclaration.getOwnProperty.returns(mockField); |
There was a problem hiding this comment.
Same comment as above.
| @@ -289,7 +295,51 @@ describe('ResourceComponent', () => { | |||
|
|
|||
| }); | |||
|
|
|||
| it('should generate a valid resource with a random 4-digit ID', () => { | |||
| let mockField = { | |||
There was a problem hiding this comment.
Might be worth creating a Sinon stub instance of Field just as a safety net to make sure the function you're stubbing exists -- I think Sinon will complain if you add a returns() to a function it hasn't stubbed through introspection. Maybe that's overkill though. Your call.
…uired As discussed with Simon, removing the code that adds the identifier field name to the auto generated data for relationships in Asset Signed-off-by: Sam Smith <smithsj@uk.ibm.com>
|
🐼 no issue? 🐼 |
|
Is it possible that this broke the automatic generation of the "$class" variable when submitting a transaction ? Since v 0.14.3 the "$class" variable does not change anymore when I select another transaction via the dropdown menu and I was wondering if this can be the cause. Below is a screenshot using one of the basic examples provided in playground : |
No description provided.