Fixed convertToFundamentalUnits to handle arrays

Author: hyperjeff

Sources/Physical/Core/Physical.swift

@@ -648,6 +648,7 @@ public struct Physical: CustomStringConvertible, Equatable, Hashable, Collection
 
 	public mutating func convertToFundamentalUnits(unitsToConvert: [Dimension] = []) {
 		var newValue = value
+		var newValues = values
 		var newUnits: DimensionDictionary = [:]
 
 		let hasNonZeroOffsets = units.containsNonZeroOffsetUnits()
@@ -674,6 +675,8 @@ public struct Physical: CustomStringConvertible, Equatable, Hashable, Collection
 				// and milesPerImperialGallon & milesPerGallon use same units!
 
 				if hasNonZeroOffsets {
+					// FIXME: add array version
+					
 					newValue = Measurement(value: value, unit: unit).converted(to: base).value
 				}
 				else {
@@ -684,7 +687,16 @@ public struct Physical: CustomStringConvertible, Equatable, Hashable, Collection
 						unitValue = 12
 					}
 
-					newValue *= pow(Measurement(value: unitValue, unit: unit).converted(to: base).value, Double(exponent.realValue))
+					let scaling = pow(Measurement(value: unitValue, unit: unit).converted(to: base).value, Double(exponent.realValue))
+					
+					if let values = values {
+						var result = [Double](repeating: 0, count: values.count)
+						cblas_daxpy(Int32(values.count), scaling, values, 1, &result, 1)
+						
+						newValues = result
+					}
+					
+					newValue *= scaling
 				}
 
 				if newUnits.keys.contains(base),
@@ -700,6 +712,7 @@ public struct Physical: CustomStringConvertible, Equatable, Hashable, Collection
 		if !newUnits.isEmpty {
 			units = newUnits
 			value = newValue
+			values = newValues
 		}
 	}
 

Tests/PhysicalTests/PhysicalTests.swift

@@ -195,6 +195,16 @@ final class PhysicalTests: XCTestCase {
 		print(acos([1, 0.993, 0.971, 0.935, 0.885, 0.823, 0.749, 0.663, 0.568, 0.465, 0.355, 0.239, 0.121, 0, -0.121, -0.239, -0.355, -0.465, -0.568, -0.663, -0.749, -0.823, -0.885, -0.935, -0.971, -0.993, -1].constant.sigfigs(3)))
 	}
 
+	func testByteArrays() {
+		let fileSizes = [1, 3, 4, -2].gigabytes.sigfigs(3)
+		let dataRate = 1.megabits.perSecond.sigfigs(3)
+		
+		let times = fileSizes / dataRate → .minutes
+		
+		XCTAssert(times[0] == 133.3.minutes) // why 4 sigfigs here?
+		XCTAssert(times[2] == 533.3.minutes)
+	}
+	
 	/*func testPowers() {
 		let a = [12.1, 3.6, -1.2, 0].miles