feat(tonic): add From<BoxError> implementation for tonic::transport::Error #2394
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #978
This PR keeps the
tonic::transport::Error
constructor methods private while allowing external users to mapBoxError
s intotonic::transpoert::Error
, which makes it possible to do something like:More details about why users would want to build
tonic::transport::Error
in the issue.Also, completely open to alternatives.