chore(tonic-transport): Export TlsError
#2209
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
@tottoto What's the process for a review here? |
ratankaliani
changed the title
TlsErrorTlsError
|
This type is specifically private for now to reduce surface area. Could you potentially build the and check for the certs outside of tonic for the moment. In addition, we need to rework the error types so that is why we are keeping them private for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When parsing errors from
tonic, we want to apply conditional logic to notify users if their machine lacks native root certificates. We currently do this based off of the string returned from the error: succinctlabs/sp1#2129.If
tonicexposed theTlsErrortype, we'd be able to do this in a more type-safe way.Solution
Expose
TlsErrorfromtonic::transport.