Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix document for helloworld-tutorial.md #1316

Merged
merged 1 commit into from
Mar 14, 2023
Merged

fix document for helloworld-tutorial.md #1316

merged 1 commit into from
Mar 14, 2023

Conversation

j13tw
Copy link
Contributor

@j13tw j13tw commented Mar 14, 2023 •
edited
Loading

Motivation

Test Tonic helloworld with helloworld-tutorial.md on Windows
with grpcurl to send data, got the IPv6 cant access, but change to IPv4 is OK.

Solution

we saw the IPv6 using with [::] not [::1], then change it.

@j13tw
fix document for helloworld-tutorial.md
0a0e0fd 
Signed-off-by: ZhengSheng0524 <j13tw@yahoo.com.tw>
@LucioFranco LucioFranco added this pull request to the merge queue Mar 14, 2023
Merged via the queue into hyperium:master with commit dcb0026 Mar 14, 2023
@j13tw j13tw deleted the fix-helloworld-tutorial branch March 15, 2023 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucioFranco LucioFranco LucioFranco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@j13tw @LucioFranco