Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If prost allows empty packages, tonic generates wrong endpoints #381

Closed
tylerhawkes opened this issue Jun 26, 2020 · 0 comments
Closed

If prost allows empty packages, tonic generates wrong endpoints #381

tylerhawkes opened this issue Jun 26, 2020 · 0 comments
Labels
A-build C-bug Category: Something isn't working

Comments

@tylerhawkes
Copy link
Contributor

tylerhawkes commented Jun 26, 2020 •
edited
Loading

Bug Report

Version

0.2.1

Platform

Linux 5.5.11-200.fc31.x86_64 #1 SMP Mon Mar 23 17:32:43 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Crates

tonic-build

Description

I have a fork of prost at https://github.com/vivint-smarthome/prost/tree/prost-no-package that allows for packages to not be specified because we really want to use tonic/prost but we have pre-defined protos without a package and adding a package is a breaking change for grpc. Tonic-build generates endpoints that begin with /.<ServiceName>/<MethodName> which is incorrect. The correct output should be /<ServiceName>/<MethodName>.

I'll submit a pull request to fix this.
@tylerhawkes tylerhawkes mentioned this issue Jun 26, 2020
Merged
@LucioFranco LucioFranco added C-bug Category: Something isn't working A-build labels Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-build C-bug Category: Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@LucioFranco @tylerhawkes