chore: Use inline format argument (#2260)

Author: tottoto

Cargo.toml

@@ -41,5 +41,8 @@ missing_docs = "warn"
 rust_2018_idioms = "warn"
 unreachable_pub = "warn"
 
+[workspace.lints.clippy]
+uninlined_format_args = "deny"
+
 [workspace.lints.rustdoc]
 broken_intra_doc_links = "deny"

examples/src/authentication/client.rs

@@ -22,7 +22,7 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> {
 
     let response = client.unary_echo(request).await?;
 
-    println!("RESPONSE={:?}", response);
+    println!("RESPONSE={response:?}");
 
     Ok(())
 }

examples/src/autoreload/server.rs

@@ -30,7 +30,7 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> {
     let addr = "[::1]:50051".parse().unwrap();
     let greeter = MyGreeter::default();
 
-    println!("GreeterServer listening on {}", addr);
+    println!("GreeterServer listening on {addr}");
 
     let server = Server::builder().add_service(GreeterServer::new(greeter));
 

examples/src/blocking/client.rs

@@ -47,7 +47,7 @@ fn main() -> Result<()> {
 
     let response = client.say_hello(request)?;
 
-    println!("RESPONSE={:?}", response);
+    println!("RESPONSE={response:?}");
 
     Ok(())
 }

examples/src/cancellation/client.rs

@@ -24,7 +24,7 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> {
         }
     };
 
-    println!("RESPONSE={:?}", response);
+    println!("RESPONSE={response:?}");
 
     Ok(())
 }

examples/src/cancellation/server.rs

@@ -37,7 +37,7 @@ impl Greeter for MyGreeter {
             Ok(Response::new(reply))
         };
         let cancellation_future = async move {
-            println!("Request from {:?} cancelled by client", remote_addr);
+            println!("Request from {remote_addr:?} cancelled by client");
             // If this future is executed it means the request future was dropped,
             // so it doesn't actually matter what is returned here
             Err(Status::cancelled("Request cancelled by client"))
@@ -74,7 +74,7 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> {
     let addr = "[::1]:50051".parse().unwrap();
     let greeter = MyGreeter::default();
 
-    println!("GreeterServer listening on {}", addr);
+    println!("GreeterServer listening on {addr}");
 
     Server::builder()
         .add_service(GreeterServer::new(greeter))

examples/src/codec_buffers/client.rs

@@ -24,7 +24,7 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> {
 
     let response = client.say_hello(request).await?;
 
-    println!("RESPONSE={:?}", response);
+    println!("RESPONSE={response:?}");
 
     Ok(())
 }

examples/src/codec_buffers/server.rs

@@ -40,7 +40,7 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> {
     let addr = "[::1]:50051".parse().unwrap();
     let greeter = MyGreeter::default();
 
-    println!("GreeterServer listening on {}", addr);
+    println!("GreeterServer listening on {addr}");
 
     Server::builder()
         .add_service(GreeterServer::new(greeter))

examples/src/compression/server.rs

@@ -31,7 +31,7 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> {
     let addr = "[::1]:50051".parse().unwrap();
     let greeter = MyGreeter::default();
 
-    println!("GreeterServer listening on {}", addr);
+    println!("GreeterServer listening on {addr}");
 
     let service = GreeterServer::new(greeter)
         .send_compressed(CompressionEncoding::Gzip)

examples/src/dynamic/server.rs

@@ -77,7 +77,7 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> {
 
     let addr = "[::1]:50051".parse().unwrap();
 
-    println!("Grpc server listening on {}", addr);
+    println!("Grpc server listening on {addr}");
 
     Server::builder()
         .add_routes(routes_builder.routes())

examples/src/dynamic_load_balance/client.rs

@@ -27,36 +27,36 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> {
         println!("Added first endpoint");
         let change = Change::Insert("1", e1);
         let res = rx.send(change).await;
-        println!("{:?}", res);
+        println!("{res:?}");
         tokio::time::sleep(tokio::time::Duration::from_secs(5)).await;
         println!("Added second endpoint");
         let change = Change::Insert("2", e2);
         let res = rx.send(change).await;
-        println!("{:?}", res);
+        println!("{res:?}");
         tokio::time::sleep(tokio::time::Duration::from_secs(5)).await;
         println!("Removed first endpoint");
         let change = Change::Remove("1");
         let res = rx.send(change).await;
-        println!("{:?}", res);
+        println!("{res:?}");
 
         tokio::time::sleep(tokio::time::Duration::from_secs(5)).await;
         println!("Removed second endpoint");
         let change = Change::Remove("2");
         let res = rx.send(change).await;
-        println!("{:?}", res);
+        println!("{res:?}");
 
         tokio::time::sleep(tokio::time::Duration::from_secs(5)).await;
         println!("Added third endpoint");
         let e3 = Endpoint::from_static("http://[::1]:50051");
         let change = Change::Insert("3", e3);
         let res = rx.send(change).await;
-        println!("{:?}", res);
+        println!("{res:?}");
 
         tokio::time::sleep(tokio::time::Duration::from_secs(5)).await;
         println!("Removed third endpoint");
         let change = Change::Remove("3");
         let res = rx.send(change).await;
-        println!("{:?}", res);
+        println!("{res:?}");
         demo_done.swap(true, SeqCst);
     });
 
@@ -68,7 +68,7 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> {
 
         let rx = client.unary_echo(request);
         if let Ok(resp) = timeout(tokio::time::Duration::from_secs(10), rx).await {
-            println!("RESPONSE={:?}", resp);
+            println!("RESPONSE={resp:?}");
         } else {
             println!("did not receive value within 10 secs");
         }

examples/src/dynamic_load_balance/server.rs

@@ -41,7 +41,7 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> {
 
         tokio::spawn(async move {
             if let Err(e) = serve.await {
-                eprintln!("Error = {:?}", e);
+                eprintln!("Error = {e:?}");
             }
 
             tx.send(()).unwrap();

examples/src/gcp/client.rs

@@ -21,7 +21,7 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> {
         .nth(1)
         .ok_or_else(|| "Expected a project name as the first argument.".to_string())?;
 
-    let bearer_token = format!("Bearer {}", token);
+    let bearer_token = format!("Bearer {token}");
     let header_value: MetadataValue<_> = bearer_token.parse()?;
 
     let data_dir = std::path::PathBuf::from_iter([std::env!("CARGO_MANIFEST_DIR"), "data"]);
@@ -44,13 +44,13 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> {
 
     let response = service
         .list_topics(Request::new(ListTopicsRequest {
-            project: format!("projects/{0}", project),
+            project: format!("projects/{project}"),
             page_size: 10,
             ..Default::default()
         }))
         .await?;
 
-    println!("RESPONSE={:?}", response);
+    println!("RESPONSE={response:?}");
 
     Ok(())
 }

examples/src/grpc-web/client.rs

@@ -23,7 +23,7 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> {
 
     let response = client.say_hello(request).await?;
 
-    println!("RESPONSE={:?}", response);
+    println!("RESPONSE={response:?}");
 
     Ok(())
 }

examples/src/grpc-web/server.rs

@@ -38,7 +38,7 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> {
         .into_inner()
         .named_layer(GreeterServer::new(greeter));
 
-    println!("GreeterServer listening on {}", addr);
+    println!("GreeterServer listening on {addr}");
 
     Server::builder()
         // GrpcWeb is over http1 so we must enable it.

examples/src/h2c/client.rs

@@ -23,7 +23,7 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> {
 
     let response = client.say_hello(request).await?;
 
-    println!("RESPONSE={:?}", response);
+    println!("RESPONSE={response:?}");
 
     Ok(())
 }

examples/src/h2c/server.rs

@@ -36,7 +36,7 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> {
     let addr: SocketAddr = "[::1]:50051".parse().unwrap();
     let greeter = MyGreeter::default();
 
-    println!("GreeterServer listening on {}", addr);
+    println!("GreeterServer listening on {addr}");
 
     let incoming = TcpListener::bind(addr).await?;
     let svc = Routes::new(GreeterServer::new(greeter)).prepare();
@@ -57,7 +57,7 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> {
                 });
             }
             Err(e) => {
-                eprintln!("Error accepting connection: {}", e);
+                eprintln!("Error accepting connection: {e}");
             }
         }
     }

examples/src/health/server.rs

@@ -55,7 +55,7 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> {
     let addr = "[::1]:50051".parse().unwrap();
     let greeter = MyGreeter::default();
 
-    println!("HealthServer + GreeterServer listening on {}", addr);
+    println!("HealthServer + GreeterServer listening on {addr}");
 
     Server::builder()
         .add_service(health_service)

examples/src/helloworld/client.rs

@@ -15,7 +15,7 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> {
 
     let response = client.say_hello(request).await?;
 
-    println!("RESPONSE={:?}", response);
+    println!("RESPONSE={response:?}");
 
     Ok(())
 }

examples/src/helloworld/server.rs

@@ -30,7 +30,7 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> {
     let addr = "[::1]:50051".parse().unwrap();
     let greeter = MyGreeter::default();
 
-    println!("GreeterServer listening on {}", addr);
+    println!("GreeterServer listening on {addr}");
 
     Server::builder()
         .add_service(GreeterServer::new(greeter))

examples/src/interceptor/client.rs

@@ -25,7 +25,7 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> {
 
     let response = client.say_hello(request).await?;
 
-    println!("RESPONSE={:?}", response);
+    println!("RESPONSE={response:?}");
 
     Ok(())
 }
@@ -34,7 +34,7 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> {
 /// `Status` here will cancel the request and have that status returned to
 /// the caller.
 fn intercept(req: Request<()>) -> Result<Request<()>, Status> {
-    println!("Intercepting request: {:?}", req);
+    println!("Intercepting request: {req:?}");
     Ok(req)
 }
 

examples/src/interceptor/server.rs

@@ -36,7 +36,7 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> {
     // structs.
     let svc = GreeterServer::with_interceptor(greeter, intercept);
 
-    println!("GreeterServer listening on {}", addr);
+    println!("GreeterServer listening on {addr}");
 
     Server::builder().add_service(svc).serve(addr).await?;
 
@@ -47,7 +47,7 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> {
 /// is returned, it will cancel the request and return that status to the
 /// client.
 fn intercept(mut req: Request<()>) -> Result<Request<()>, Status> {
-    println!("Intercepting request: {:?}", req);
+    println!("Intercepting request: {req:?}");
 
     // Set an extension that can be retrieved by `say_hello`
     req.extensions_mut().insert(MyExtension {

examples/src/json-codec/client.rs

@@ -22,7 +22,7 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> {
 
     let response = client.say_hello(request).await?;
 
-    println!("RESPONSE={:?}", response);
+    println!("RESPONSE={response:?}");
 
     Ok(())
 }

examples/src/json-codec/server.rs

@@ -37,7 +37,7 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> {
     let addr = "[::1]:50051".parse().unwrap();
     let greeter = MyGreeter::default();
 
-    println!("GreeterServer listening on {}", addr);
+    println!("GreeterServer listening on {addr}");
 
     Server::builder()
         .add_service(GreeterServer::new(greeter))

examples/src/load_balance/client.rs

@@ -22,7 +22,7 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> {
 
         let response = client.unary_echo(request).await?;
 
-        println!("RESPONSE={:?}", response);
+        println!("RESPONSE={response:?}");
     }
 
     Ok(())

examples/src/load_balance/server.rs

@@ -41,7 +41,7 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> {
 
         tokio::spawn(async move {
             if let Err(e) = serve.await {
-                eprintln!("Error = {:?}", e);
+                eprintln!("Error = {e:?}");
             }
 
             tx.send(()).unwrap();

examples/src/mock/mock.rs

@@ -53,7 +53,7 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> {
 
     let response = client.say_hello(request).await?;
 
-    println!("RESPONSE={:?}", response);
+    println!("RESPONSE={response:?}");
 
     Ok(())
 }

examples/src/multiplex/client.rs

@@ -25,15 +25,15 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> {
 
     let response = greeter_client.say_hello(request).await?;
 
-    println!("GREETER RESPONSE={:?}", response);
+    println!("GREETER RESPONSE={response:?}");
 
     let request = tonic::Request::new(EchoRequest {
         message: "hello".into(),
     });
 
     let response = echo_client.unary_echo(request).await?;
 
-    println!("ECHO RESPONSE={:?}", response);
+    println!("ECHO RESPONSE={response:?}");
 
     Ok(())
 }

examples/src/richer-error/client.rs

@@ -29,15 +29,15 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> {
 
             if let Some(bad_request) = err_details.bad_request() {
                 // Handle bad_request details
-                println!(" {:?}", bad_request);
+                println!(" {bad_request:?}");
             }
             if let Some(help) = err_details.help() {
                 // Handle help details
-                println!(" {:?}", help);
+                println!(" {help:?}");
             }
             if let Some(localized_message) = err_details.localized_message() {
                 // Handle localized_message details
-                println!(" {:?}", localized_message);
+                println!(" {localized_message:?}");
             }
 
             println!();
@@ -46,7 +46,7 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> {
         }
     };
 
-    println!(" Successful response received.\n\n {:?}\n", response);
+    println!(" Successful response received.\n\n {response:?}\n");
 
     Ok(())
 }