[WIP] add server-side C API #2807
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanmonstar
requested changes
Apr 8, 2022
| use super::io::hyper_io; | ||
| use super::task::{hyper_executor, hyper_task, WeakExec}; | ||
|
|
||
| pub struct hyper_http(Http<WeakExec>); |
There was a problem hiding this comment.
You couldn't know this, but I'm not a fan of the name that's currently Http in hyper. I think this C API type might want to follow the client-side naming, so maybe hyper_serverconn_options? And then similarly with the related functions.
| } | ||
|
|
||
| type hyper_service_callback = | ||
| extern "C" fn(*mut c_void, *mut hyper_request, *mut hyper_response) -> (); |
There was a problem hiding this comment.
So, it looks like this would require that in C, the callback is synchronous. It must return a response, it can't return a future. I worry that this might make servers in C just do everything in a blocking style, which would be bad for the server.
Would it be hard to have this callback return a *mut hyper_task? I haven't thought too hard about it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2797. The API can be called but does not really work yet.
Since I am not yet familiar with the whole project, I would like to hear more advice from the community, especially those who previously worked on the C API.