Skip to content

Commit 91df244

Browse files
committed
fix(headers): Don't display q if q=1 in quality item.
Fixes #281
1 parent 93821fc commit 91df244

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

src/header/shared/quality_item.rs

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,12 @@ impl<T> QualityItem<T> {
2828

2929
impl<T: fmt::Display> fmt::Display for QualityItem<T> {
3030
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
31-
write!(f, "{}; q={}", self.item, format!("{:.3}", self.quality).trim_right_matches(['0', '.'].as_slice()))
31+
if self.quality == 1.0 {
32+
write!(f, "{}", self.item)
33+
} else {
34+
write!(f, "{}; q={}", self.item,
35+
format!("{:.3}", self.quality).trim_right_matches(&['0', '.'][]))
36+
}
3237
}
3338
}
3439

@@ -79,7 +84,7 @@ pub fn qitem<T>(item: T) -> QualityItem<T> {
7984
#[test]
8085
fn test_quality_item_show1() {
8186
let x = qitem(Chunked);
82-
assert_eq!(format!("{}", x), "chunked; q=1");
87+
assert_eq!(format!("{}", x), "chunked");
8388
}
8489
#[test]
8590
fn test_quality_item_show2() {

0 commit comments

Comments
 (0)