fix(http2): send INTERNAL_ERROR when user's Service errors

seanmonstar · seanmonstar · commit 8f926a0daeaf · 2019-02-28T16:04:53.000-08:00
diff --git a/src/proto/h2/server.rs b/src/proto/h2/server.rs
@@ -209,7 +209,12 @@ where
                             }
                             return Ok(Async::NotReady);
                         }
-                        Err(e) => return Err(::Error::new_user_service(e)),
+                        Err(e) => {
+                            let err = ::Error::new_user_service(e);
+                            warn!("http2 service errored: {}", err);
+                            self.reply.send_reset(Reason::INTERNAL_ERROR);
+                            return Err(err);
+                        },
                     };
 
                     let (head, mut body) = res.into_parts();

Original file line number	Diff line number	Diff line change
`@@ -209,7 +209,12 @@ where`
`209`	`209`	`}`
`210`	`210`	`return Ok(Async::NotReady);`
`211`	`211`	`}`
`212`		`- Err(e) => return Err(::Error::new_user_service(e)),`
	`212`	`+ Err(e) => {`
	`213`	`+ let err = ::Error::new_user_service(e);`
	`214`	`+ warn!("http2 service errored: {}", err);`
	`215`	`+ self.reply.send_reset(Reason::INTERNAL_ERROR);`
	`216`	`+ return Err(err);`
	`217`	`+ },`
`213`	`218`	`};`
`214`	`219`
`215`	`220`	`let (head, mut body) = res.into_parts();`