Skip to content

Commit dce81a0

Browse files
authored
refactor: remove legacy::client workaround for fixed race condition in mpsc channel (#159)
Co-authored-by: JESS IZEN <jlizen@amazon.com>
1 parent 7a39c88 commit dce81a0

File tree

1 file changed

+0
-11
lines changed

1 file changed

+0
-11
lines changed

src/client/legacy/client.rs

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -344,17 +344,6 @@ where
344344
extra.set(res.extensions_mut());
345345
}
346346

347-
// As of futures@0.1.21, there is a race condition in the mpsc
348-
// channel, such that sending when the receiver is closing can
349-
// result in the message being stuck inside the queue. It won't
350-
// ever notify until the Sender side is dropped.
351-
//
352-
// To counteract this, we must check if our senders 'want' channel
353-
// has been closed after having tried to send. If so, error out...
354-
if pooled.is_closed() {
355-
return Ok(res);
356-
}
357-
358347
// If pooled is HTTP/2, we can toss this reference immediately.
359348
//
360349
// when pooled is dropped, it will try to insert back into the

0 commit comments

Comments
 (0)