Skip to content

Conversation

ikrivosheev
Copy link
Contributor

Copy link
Member

@seanmonstar seanmonstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@@ -1,5 +1,6 @@
#![deny(missing_debug_implementations, missing_docs, unreachable_pub)]
#![cfg_attr(test, deny(warnings))]
#![cfg_attr(docsrs, feature(doc(auto_cfg)))]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the RFC, it also needs #![doc(auto_cfg)].

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, after run: $ RUSTDOCFLAGS="--cfg docsrs" cargo +nightly doc --features full

I see:
Screenshot from 2025-04-02 18-14-51

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, you're right, it's set to true by default.

@seanmonstar seanmonstar merged commit 7b3c4eb into hyperium:master Apr 2, 2025
8 checks passed
@ikrivosheev ikrivosheev deleted the fix/docs branch April 2, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants