feat: not return UnexpectedEof when server drops without close_notify

Author: jmwample

src/proto/connection.rs

@@ -482,10 +482,7 @@ where
                 // without error
                 //
                 // See https://github.com/hyperium/hyper/issues/3427
-                if self.streams.is_server()
-                    && self.streams.is_buffer_empty()
-                    && matches!(kind, io::ErrorKind::UnexpectedEof)
-                {
+                if self.streams.is_buffer_empty() && matches!(kind, io::ErrorKind::UnexpectedEof) {
                     *self.state = State::Closed(Reason::NO_ERROR, Initiator::Library);
                     return Ok(());
                 }

src/proto/streams/streams.rs

@@ -337,10 +337,6 @@ impl<B> DynStreams<'_, B> {
         self.send_buffer.is_empty()
     }
 
-    pub fn is_server(&self) -> bool {
-        self.peer.is_server()
-    }
-
     pub fn recv_headers(&mut self, frame: frame::Headers) -> Result<(), Error> {
         let mut me = self.inner.lock().unwrap();
 

tests/h2-tests/tests/client_request.rs

@@ -1914,7 +1914,7 @@ async fn receive_settings_frame_twice_with_second_one_non_empty() {
 }
 
 #[tokio::test]
-async fn server_drop_connection_unexpectedly_return_unexpected_eof_err() {
+async fn server_drop_connection_without_close_notify() {
     h2_support::trace_init!();
     let (io, mut srv) = mock::new();
 
@@ -1944,11 +1944,7 @@ async fn server_drop_connection_unexpectedly_return_unexpected_eof_err() {
                 .await
                 .expect("request");
         });
-        let err = h2.await.expect_err("should receive UnexpectedEof");
-        assert_eq!(
-            err.get_io().expect("should be UnexpectedEof").kind(),
-            io::ErrorKind::UnexpectedEof,
-        );
+        let err = h2.await.unwrap();
     };
     join(srv, h2).await;
 }